search

geffy / tffm

TensorFlow implementation of an arbitrary order Factorization Machine
MIT License
780 stars 176 forks source link

get_shorter_decompositions in util.py #28

Open yvesx opened 7 years ago

yvesx commented 7 years ago

Hi, thank you for making this great package! I just noticed this example for get_shorter_decompositions function in util.py:

    Example
    -------
    decompositions, counts = get_shorter_decompositions([1, 2, 3])
        decompositions == [(1, 5), (2, 4), (3, 3), (6,)]
        counts == [ 2.,  1.,  1.,  2.]

I ran this example myself and got the counts as [2, 2, 1, 1] instead of [2, 1, 1, 2]. It seems just a typo in the example in the docstring, nothing wrong with the code itself.