gefyrahq / gefyra

Blazingly-fast :rocket:, rock-solid, local application development :arrow_right: with Kubernetes.
https://gefyra.dev
Apache License 2.0
692 stars 28 forks source link

Gefyra unbridge does not remove them from the list #108

Closed georgkrause closed 1 year ago

georgkrause commented 2 years ago

I want to unbridge everything, so I am running gefyra unbridge -A.

The command succeeds, lists all the bridges it is removing and as far as I can tell no bridge is actually in place anymore.

But when I run gefyra list --bridges afterwards, I still get them listed:

gefyra unbridge -A
[INFO] Removing Bridge spacecrafts-ireq-20220630135014-0
[INFO] Removing Bridge spacecrafts-ireq-20220630135014-1
[INFO] Removing Bridge spacecrafts-ireq-20220630135411-0
[INFO] Removing Bridge spacecrafts-ireq-20220630135411-1
[INFO] Removing Bridge spacecrafts-ireq-20220630135650-0
[INFO] Removing Bridge spacecrafts-ireq-20220630135650-1
[INFO] Removing Bridge spacecrafts-ireq-20220705102421-0
SteinRobert commented 2 years ago

That seems strange! Thanks for reporting! I suspect there is something wrong with your output though. It looks like the output itself is from unbridge not from list --bridges.

Could you provide an example to reproduce? It looks like it's part of the spacecrafts guide. Can I reproduce it following the guide?

georgkrause commented 2 years ago

Yes, I messed up my post. the output was from gefyra unbridge -A, but:

gefyra list --bridges
spacecrafts-ireq-20220630135014-0
spacecrafts-ireq-20220630135014-1
spacecrafts-ireq-20220630135411-0
spacecrafts-ireq-20220630135411-1
spacecrafts-ireq-20220630135650-0
spacecrafts-ireq-20220630135650-1

Well, I couldn't make bridging work, so the guide does not cover it. But I tried gefyra bridge -N myspacecraft -n default --deployment spacecrafts --container-name spacecrafts -p 8000:8000 in addition to the guide, so probably can reproduce it that way. I also run into #107 while bridging.

buschNT commented 2 years ago

I also run into https://github.com/gefyrahq/gefyra/issues/107 while bridging.

Same issue here. gefyra unbridge --all does not seem to have any effect after #107 . gefyra unbridge --name ... neither though. gefyra down is working, but the gefyra namespace is not terminationg properly

buschNT commented 2 years ago

I managed to solve the terminating issue of gefyra down by removing the operator.gefyra.dev/kopf-finalizer from the Finalizers of the interceptrequests.gefyra.dev resource. Not sure if that's super clean, though, meaning if the cluster is in a proper state afterwards. Nevertheless, for me it worked and gefyra up was working again, too.

Thanks @tschale for your support :D

Schille commented 2 years ago

@buschNT this may happens if Operator lost connection to the bridges (for example if it terminated or something), meaning there are remainder bridges which in turn cannot be removed due to the missing finalizer.

SteinRobert commented 1 year ago

Resolved with v2

georgkrause commented 1 year ago

@SteinRobert uh, 2.0 how exciting. Congratulations!!