search

gefyrahq / gefyra

Blazingly-fast :rocket:, rock-solid, local application development :arrow_right: with Kubernetes.
https://gefyra.dev
Apache License 2.0
692 stars 28 forks source link

Different meaning of `-N, --name` argument between commands #141

Open buschNT opened 2 years ago

buschNT commented 2 years ago

Since #137 has been opened, I wanted to mention the following observation. The -N, --name argument has a different meaning for gefyra run/bridge and gefyra unbridge:

(https://gefyra.dev/reference/cli/)

The gefyra unbridge --name argument corresponds to the gefyra bridge --bridge-name argument. Would it make sense to rename the --name argument from the unbridge command into --bridge-name?

Schille commented 2 years ago

I think, if there is only one required argument then why not making it a positional argument (removing the --name entirely)?

Schille commented 2 years ago

@SteinRobert As far as I can tell we removed the option to name bridges entirely. Hence, the --name argument only refers to a local container instance. I still think we should also remove the --name argument from the gefyra bridge and replace it with a positional argument. Same for the target argument.

For instance, gefyra bridge my-local-container deploy/my-deployment/cone with no additional switches. The port would still be missing. :thinking: Thinking is still in progress.