search

gefyrahq / gefyra

Blazingly-fast :rocket:, rock-solid, local application development :arrow_right: with Kubernetes.
https://gefyra.dev
Apache License 2.0
666 stars 26 forks source link

False positive on installation #222

Closed trincano closed 1 year ago

trincano commented 1 year ago

What happened?

False positive. When installing Gefyra on linux, I was informed that the "installation was successful", although I didn't have the unzip package installed on the operating system. When executing the gefyra command in the shell the command was not recognized. I had to install unzip then install Gefyra again. Then it worked.

What did you expect to happen?

Report that dependency (unzip) was not present

How can we reproduce it (as minimally and precisely as possible)?

Install Gefyra on Linux without the unzip package already installed

What Kubernetes setup are you working with?

```console $ kubectl version # paste output here ```

OS version

```console # On Linux: $ cat /etc/os-release # paste output here $ uname -a # paste output here # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ```

Anything else we need to know?

No response

SteinRobert commented 1 year ago

Hey @trincano thank you for reporting! If you're inclined to help with that feel free to open a PR. This repo is part of the Hacktoberfest event - in case you'd like to benefit from that :) We'd review the PR shortly then.

georgkrause commented 1 year ago

@SteinRobert A fix is available here https://github.com/gefyrahq/gefyra/pull/226

SteinRobert commented 1 year ago

The installer now prints a warning if the given tools are not available! Thank you for reporting the issue @trincano and thank you for the contribution @georgkrause ! Resolved via #230 and #226