gefyrahq / gefyra

Blazingly-fast :rocket:, rock-solid, local application development :arrow_right: with Kubernetes.
https://gefyra.dev
Apache License 2.0
689 stars 28 forks source link

gefyra-run: certain (docker) runtime errors are ignored (RC=0) #746

Open crkurz opened 5 days ago

crkurz commented 5 days ago

What happened?

gefyra-run only fails (RC>0) in case of early errors, e.g. invalid parameters. But in case of Docker errors like

      409 Client Error for http+docker://localhost/v1.40/containers/0f2a06510ea1e5d0721f59fea15a1cc1de8f66ea31716dda408cf122e9e82705/exec: Conflict ("Container 0f2a06510ea1e5d0721f59fea15a1cc1de8f66ea31716dda408cf122e9e82705 is not running")

docker-run prints the error msg, but still returns RC=0. In this particular case the cargo container was down due to a docker-daemon restart.

What did you expect to happen?

gefyra-run should have return RC>0.

RC handling is import when gefyra-run is used for automation or inside some wrapper scripts.

Please provide the output of gefyra check.

.

How can we reproduce it (as minimally and precisely as possible)?

.

What Kubernetes setup are you working with?

.

OS version

.

Anything else we need to know?

No response