search

gegerlan / aog

Check out taber's updated 2022 version at taberenc/AOG_2022
https://github.com/taberenc/AOG_2022
44 stars 66 forks source link

Dog Garnet can enter the Potts residence, even if she shouldn't be able to. #86

Closed gegerlan closed 12 years ago

gegerlan commented 12 years ago

The night check is incorrectly checking if the actor is in the party, rather than the switch (24).

gegerlan commented 12 years ago

The different actors aren't used for Garnet different states. The reasoning is that you can't use the actors when doing page conditions, making Switches a more versatile option. It also fixes a number of bugs related to actually changing the main actor of the party, without treating her as a completely different person.

Open one of the stray dogs to see how the check if Garnet is a dog, works.

gegerlan commented 12 years ago

Fix in 6c5c29a.

The same block that exists for the players house, is now there with the potts residence.

omglolwtfbbq commented 12 years ago

Do you apply this to all doors or what ?Why just players house and Potts ?

Date: Sun, 13 May 2012 20:28:31 -0700 From: reply@reply.github.com To: sparesubject159753@hotmail.com Subject: Re: [aog] Dog Garnet can enter the Potts residence, even if she shouldn't be able to. (#86)

Fix in 6c5c29a.

The same block that exists for the players house, is now there with the potts residence.

Reply to this email directly or view it on GitHub: https://github.com/gegerlan/aog/issues/86#issuecomment-5682078

gegerlan commented 12 years ago

This fix was only for the Potts' house, and is a copy of an already existing solution implemented for the entrance to the player's home.

Most of the other places has dog specific behaviour defined in them already (or at least makes sure that some events doesn't trigger). This fix is just faster than going through all the events indoors, checking if the interactions are appropriate for a dog; since you're blocking access to it altogether.

Date: Sun, 13 May 2012 23:27:08 -0700 From: reply@reply.github.com To: gegerlan2@hotmail.com Subject: Re: [aog] Dog Garnet can enter the Potts residence, even if she shouldn't be able to. (#86)

Do you apply this to all doors or what ?Why just players house and Potts ?

Date: Sun, 13 May 2012 20:28:31 -0700 From: reply@reply.github.com To: sparesubject159753@hotmail.com Subject: Re: [aog] Dog Garnet can enter the Potts residence, even if she shouldn't be able to. (#86)

Fix in 6c5c29a.

The same block that exists for the players house, is now there with the potts residence.

Reply to this email directly or view it on GitHub: https://github.com/gegerlan/aog/issues/86#issuecomment-5682078

Reply to this email directly or view it on GitHub: https://github.com/gegerlan/aog/issues/86#issuecomment-5683372