Open vincefn opened 6 years ago
Dear Vincent,
thanks for your hint, you are right, for an out-of-place complex->real transform, where both in- and output arrays are provided by the user, the real=True keyword should not be necessary (only for an inplace transform).
Real<->complex transforms are a late addition and still lack tests, I did not yet dare to fiddle around with the interface.
Gregor
Is there any case where the real
keyword is used beside real<->complex transforms ? Can I submit a PR deprecating this keyword ?
Thanks, Vincent
I just saw the inline-real2real branch. No deprecation then ? But may be useful to recognize the complex hermitian->real transform without the keyword. Could inline real2real also be recognized automatically from having in_array.dtype=np.float* and out_array=None ?
I have a question regarding complex<->real plans.
You can create a real<->complex plans using:
... and cl_d_ft is a complex hermitian array - OK However, to create a complex(half-hermitian array)->real plan, you need to use
real=True
keyword, but why is it needed ? Should it not be sufficient to detect that the input is complex and output real to trigger the creation of a complex-hermitian->real plan ? (it took me a while to find that keyword was needed, that's why I'm asking...)