search

geheur / More-menu-entry-swaps

https://github.com/runelite/plugin-hub#creating-new-plugins
BSD 2-Clause "Simplified" License
7 stars 13 forks source link

Would it be possible to add the bank swaps for bank-like interfaces, e.g. seed vault, price guide, etc? #37

Closed swirle13 closed 5 months ago

swirle13 commented 6 months ago

I often find myself attempting to use shift clicking to perform deposit/withdraw/buy/sell all everywhere, but the runelite shift clicking option only works in banks and shops.

My most frequent issue is when I'm trying to shift click deposit/withdraw all my seeds into/from the seed vault in the farming guild. I deposit/withdraw one seed when I expected to deposit/withdraw all. I also run into this when I'm checking prices for the loot I've gotten via the price guide menu, where I also have to right click > add-all.

Would it be possible for this plugin to support those screens as well?

I've otherwise had to update every single shift click option for every seed type, once for each deposit from inventory and withdrawing from the vault, which has been tedious, and I'm sure others have run into this issue too.

This issue has been sitting open on runelite's issues for a couple of years here. I bumped it about a month ago, but they have so many requests that I'm sure it's low priority.

geheur commented 5 months ago

https://github.com/runelite/plugin-hub/pull/5764

I can't test the seed vault so hopefully it's correct.

geheur commented 5 months ago

I'm assuming it works since no one has complained.

swirle13 commented 3 months ago

Should "Withdraw-All" occur when holding shift? From the items in the seed vault, there is no change when holding shift, but when depositing from the inventory, it does successfully change to "Deposit-all" when holding shift.

geheur commented 2 months ago

It was broken and it will be fixed in 2.5.5 or later.