Config Improvements, Object Highlight Bug Fixes

geheur / rainbow-rave

rainbow nightmare

BSD 2-Clause "Simplified" License

1 stars 1 forks source link

Config Improvements, Object Highlight Bug Fixes #2

Open llaver opened 2 years ago

llaver commented 2 years ago

Config Improvements Config dropdowns were using 'Some'. I've updated those to better indicate their purpose.

Updates enums to use slightly more descriptive language
Adds tile markers note

Object Highlight Bug Fixes There is a bug where if you turn the plugin off then back on while logged in, the Object plugin would not add the scene objects to the List until a new chunk was loaded or the user logged out and back in again. This adds a function to startup that will find those objects and add their points to the List.

Adds initiateObjects method to handle finding scene>tiles>objects and adding object/points to List/Map
Adds initiateObjects to startup, runs if user is logged in and no objects in either List

Other

Cleaned up for loops by utilizing Array.fill()
Upped OverlayPriority of Tile and Object Overlays due to their associated plugins occasionally rendering on top

geheur commented 2 years ago

Lmao the options were "same" not "some" (but the change is still good lol).

I made some review comments, other than that there are some redundant comments. I've only ever done one PR review so idk how much of a stickler to be, if you want I can just do those edits myself.

Also this add objects on startup thing isn't working for me. When I flick rainbow rave on and off it does not rainbow my marked object but when I teleport away and back it does. I have "Marked" set in the config and a clay rock in the crafting guild is the marked object.

llaver commented 2 years ago

Lmao the options were "same" not "some" (but the change is still good lol).

Oops, typo 🤐

I made some review comments, other than that there are some redundant comments. I've only ever done one PR review so idk how much of a stickler to be, if you want I can just do those edits myself.

Comments were purposefully over detailed at times. Can remove some if you would like.

Also this add objects on startup thing isn't working for me. When I flick rainbow rave on and off it does not rainbow my marked object but when I teleport away and back it does. I have "Marked" set in the config and a clay rock in the crafting guild is the marked object.

I noticed the same thing yesterday. Something fishy is going on, I'll take another look at it.

geheur commented 2 years ago

One thing I noticed earlier is that there is a hub plugin "Improved Tile Indicators" which might rely on ground markers priority to render properly; I wonder if this change to the priority would negatively impact that plugin.