Open llaver opened 2 years ago
Lmao the options were "same" not "some" (but the change is still good lol).
I made some review comments, other than that there are some redundant comments. I've only ever done one PR review so idk how much of a stickler to be, if you want I can just do those edits myself.
Also this add objects on startup thing isn't working for me. When I flick rainbow rave on and off it does not rainbow my marked object but when I teleport away and back it does. I have "Marked" set in the config and a clay rock in the crafting guild is the marked object.
Lmao the options were "same" not "some" (but the change is still good lol).
Oops, typo 🤐
I made some review comments, other than that there are some redundant comments. I've only ever done one PR review so idk how much of a stickler to be, if you want I can just do those edits myself.
Comments were purposefully over detailed at times. Can remove some if you would like.
Also this add objects on startup thing isn't working for me. When I flick rainbow rave on and off it does not rainbow my marked object but when I teleport away and back it does. I have "Marked" set in the config and a clay rock in the crafting guild is the marked object.
I noticed the same thing yesterday. Something fishy is going on, I'll take another look at it.
One thing I noticed earlier is that there is a hub plugin "Improved Tile Indicators" which might rely on ground markers priority to render properly; I wonder if this change to the priority would negatively impact that plugin.
Config Improvements Config dropdowns were using 'Some'. I've updated those to better indicate their purpose.
Object Highlight Bug Fixes There is a bug where if you turn the plugin off then back on while logged in, the Object plugin would not add the scene objects to the List until a new chunk was loaded or the user logged out and back in again. This adds a function to
startup
that will find those objects and add their points to the List.initiateObjects
method to handle finding scene>tiles>objects and adding object/points to List/MapinitiateObjects
to startup, runs if user is logged in and no objects in either ListOther
Array.fill()
OverlayPriority
of Tile and Object Overlays due to their associated plugins occasionally rendering on top