geheur / weapon-animation-replacer

BSD 2-Clause "Simplified" License
4 stars 3 forks source link

Cursed banana animation repeats too early? #13

Closed BluntOSRS closed 2 years ago

BluntOSRS commented 2 years ago

Hi, I've been looking for some fixes to this issue, to no avail.

I'm trying to get the cursed banana animation to play fully, but it repeats early and it looks a bit off. I noticed you addressed this in the godsword guy's post, is there a fix for this yet?

Thanks, -B

geheur commented 2 years ago

Fix isn't released yet but it should be done soon.

On Fri, Aug 27, 2021, 5:10 AM BluntOSRS @.***> wrote:

Hi, I've been looking for some fixes to this issue, to no avail.

I'm trying to get the cursed banana animation to play fully, but it repeats early and it looks a bit off. I noticed you addressed this in the godsword guy's post, is there a fix for this yet?

Thanks, -B

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/geheur/weapon-animation-replacer/issues/13, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4TVP7XGQ6YSNKG5RHSTDLT656EFANCNFSM5C5NIWPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

BluntOSRS commented 2 years ago

Thank you so much, is there an ETA on the fix? I am in dire need of this. No pressure at all though, thank you so much for being so quick to respond :)

geheur commented 2 years ago

Is like to submit it today or tomorrow but there's a lot more in this update than just this fix so it could take a few days beyond that before someone at Runelite has time to look it over and approve it.

If your need is very very dire, you could try building the plugin yourself, as the master branch in this repo has the fix in it.

On Fri, Aug 27, 2021, 5:17 AM BluntOSRS @.***> wrote:

Thank you so much, is there an ETA on the fix? I am in dire need of this. No pressure at all though, thank you so much for being so quick to respond :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/geheur/weapon-animation-replacer/issues/13#issuecomment-907159381, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4TVP6HYI27QVQYAGVNGUTT6564LANCNFSM5C5NIWPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

geheur commented 2 years ago

I could also send you a copy of Runelite with the updated plugin bundled into it, if you need it earlier.

On Fri, Aug 27, 2021, 5:17 AM BluntOSRS @.***> wrote:

Thank you so much, is there an ETA on the fix? I am in dire need of this. No pressure at all though, thank you so much for being so quick to respond :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/geheur/weapon-animation-replacer/issues/13#issuecomment-907159381, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4TVP6HYI27QVQYAGVNGUTT6564LANCNFSM5C5NIWPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

BluntOSRS commented 2 years ago

If it's not a hassle, I would really appreciate the bundled version - my programming/coding knowledge is incredibly poor.

BluntOSRS commented 2 years ago

My discord is Blunt#4241 :)

geheur commented 2 years ago

duplicate of the godsword issue (#9), probably.