search

geheur / weapon-animation-replacer

BSD 2-Clause "Simplified" License
4 stars 3 forks source link

Pose animations not tied to equipped weapon are overriden. This should be changed not to happen. #16

Closed geheur closed 2 years ago

geheur commented 2 years ago

Some animations are done by changing the pose animation. They are overridden by the animation override (if one is present). This behavior is unexpected and undesirable.

Possible animations that are affected by this: Underwater swimming. Flying carpet kneeling. fishing trawler crash swimming.

Definitely affected: Gnome stronghold log cross. Tob floating animation after being defeated. Brimhaven agility course monkey bars.

geheur commented 2 years ago

fixed in 9801a2696a6c55fdaba3932b6c23547cb5d3ef7c.

geheur commented 2 years ago

Or rather, a mechanism to prevent this has been added and the animations for which I know this to happen have been marked to not be replaced.

geheur commented 2 years ago

It might be nice to let people not have this behavior - e.g. for underwater swimming maybe I don't want to see it when I'm picking seaweed. So it could be nice to have this - maybe you could use "underwater swimming animations" as a trigger "item". Seems like a minor issue though so I probably won't do it.