search

geheur / weapon-animation-replacer

BSD 2-Clause "Simplified" License
5 stars 3 forks source link

Throwing Knifes wont animate #21

Closed Soxxworld closed 2 years ago

Soxxworld commented 2 years ago

Hey man, can you fix it so that the throwing knifes will be animated??

geheur commented 2 years ago

which items are not working (specifically what throwing knives do you have equipped and what do you have set in the plugin?). Also are they poisoned?

Soxxworld commented 2 years ago

Dragon Knife p++

Yes, I used to used them with the d claw special animation. It won’t work now.

Sent from my iPhone

On Feb 27, 2022, at 4:10 PM, geheur @.***> wrote:

 which items are not working (specifically what throwing knives do you have equipped and what do you have set in the plugin?). Also are they poisoned?

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

geheur commented 2 years ago

yeah I forgot to add poisoned knives originally; they have a different animation id as the non-poisoned version. Should be easy to fix.

Soxxworld commented 2 years ago

Please if you could do that I’d appreciate it greatly!

Let me know after so I can try it out.

Sent from my iPhone

On Feb 27, 2022, at 7:42 PM, geheur @.***> wrote:

 yeah I forgot to add poisoned knives originally; they have a different animation id as the non-poisoned version. Should be easy to fix.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

Soxxworld commented 2 years ago

Status?

Soxxworld commented 2 years ago

???

geheur commented 2 years ago

yeah im doing that right now actually.

Soxxworld commented 2 years ago

Perfect.

Sent from my iPhone

On Mar 2, 2022, at 6:01 PM, geheur @.***> wrote:

 yeah im doing that right now actually.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

Soxxworld commented 2 years ago

Please let me know after it’s done

Sent from my iPhone

On Mar 2, 2022, at 6:10 PM, Brandon Harding @.***> wrote:

Perfect.

Sent from my iPhone

On Mar 2, 2022, at 6:01 PM, geheur @.***> wrote:

 yeah im doing that right now actually.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

Soxxworld commented 2 years ago

I

Sent from my iPhone

On Mar 2, 2022, at 6:01 PM, geheur @.***> wrote:

 yeah im doing that right now actually.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

geheur commented 2 years ago

https://github.com/runelite/plugin-hub/pull/2439 it will be in when this is merged. version number will be 2.2.2

Soxxworld commented 2 years ago

Runelite has to update?

Sent from my iPhone

On Mar 3, 2022, at 12:52 AM, geheur @.***> wrote:

 runelite/plugin-hub#2439 it will be in when this is merged. version number will be 2.2.2

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

Soxxworld commented 2 years ago

Can you tell me how to activate the dragon knifes to animals like the d claws please?

Sent from my iPhone

On Mar 3, 2022, at 1:31 AM, Brandon Harding @.***> wrote:

Runelite has to update?

Sent from my iPhone

On Mar 3, 2022, at 12:52 AM, geheur @.***> wrote:

 runelite/plugin-hub#2439 it will be in when this is merged. version number will be 2.2.2

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

geheur commented 2 years ago

The change I linked earlier isn't in yet. Also I don't know what you mean by animals.

Soxxworld commented 2 years ago

i didnt mean animals.

Soxxworld commented 2 years ago

When will it be in?? Will it be today?

geheur commented 2 years ago

idk when. whenever the runelite people get around to reviewing plugin hub updates.

geheur commented 2 years ago

This has been added. You can now choose non-dragon, dragon, or poisoned dragon knives as animations and the plugin should correctly replace these animations.