search

geheur / weapon-animation-replacer

BSD 2-Clause "Simplified" License
4 stars 3 forks source link

head disappears when changing some head pieces. #26

Closed Frooby91 closed 1 year ago

Frooby91 commented 1 year ago

whenever I try to change the head piece the head seems to disappear. It seems to be if your head is covered/not default then it just vanishes if you transmog something over it.

This happened with me with replacing the graceful hood for an infinity hat. This also happened when replacing the lumberjack hood.

Jademalo commented 1 year ago

This seems to happen when your base head model isn't visible.

If you unequip your head item, it will normally work. However if you've got a helmet on that covers your base head model, your head will turn invisible.

Would very much like to see this fixed too, I believe the solution is having the addon save your base model in some way.

geheur commented 1 year ago

The solution is to hardcode which helms require your head to be visible, like how Fashionscape does it. Until then, go to "show/hide slots" in the model swap picker and click show head and show jaw.

Jademalo commented 1 year ago

Awesome, can confirm this works.

Only issue now is if you enable a "Show hair" profile without your character having shown their hair since runelite was opened, you end up bald. I assume this is because the plugin doesn't know what your hair is until the headpiece is removed?

It's fine if it's been shown once, I assume that would need character base models to be cached across restarts?

geheur commented 1 year ago

it's just a hairstyle id not the character model. it could be saved when you take your helmet off. It doesn't right now though.

Jademalo commented 1 year ago

Are there any other parts of the base character that show up with various bits of gear? It would definitely be nice if it did save for those across client restarts.

It would make using outfits that show hair much easier since you'd not have to remove everything on login, and would be great for outfits that still have hair when you're using a full face helmet. Obvious example would be conditional Void outfit swaps depending on which helmet you were using.

Absolutely love the plugin btw, the way you can set up conditional swaps is super, super nice.

geheur commented 1 year ago

hair jaw and arms.

geheur commented 1 year ago

Coming in 3.3.1 https://github.com/runelite/plugin-hub/pull/4322 (both things, auto hide/show hair/jaw/arms and remembering base slot).

geheur commented 1 year ago

Released in 3.3.1