search

geheur / weapon-animation-replacer

BSD 2-Clause "Simplified" License
4 stars 3 forks source link

Search function limited to 24 #27

Closed Friedea closed 1 year ago

Friedea commented 1 year ago

Hi! I am not sure how to get in touch with the creator of this wonderful plugin so I thought I could try opening a small issue/suggestion here.

Basically, the searching function for the display transmog is limited to 24, so if I were to search for the Keldagrim Blue Skirt (which is ID'd only by "Skirt") it is hidden beyond the 24 search limit display of the other skirts like rune plateskirts and their variants etc.

Proposition - To allow a scroll down display like the G.E search function to display >24 items. P.S. another side benefit is to let people browse generic terms so they can find matches for their outfit better!

Thank you for taking the time to read this, it is a wonderful plugin and thanks a bunch for working on it!

geheur commented 1 year ago

I was aware of this issue but I hadn't run into any issues where I couldn't select an item so I never fixed it.

For now you can use the item id (5052 I think).

You can get ids by clicking "edit source" on the item's wiki page, the id will be in there I think.

Friedea commented 1 year ago

Okay that works too, didn't know you can search by ID. Thanks very much!

geheur commented 1 year ago

d3994a88af899ba7c3315de810b2a6c43be4c6ae adds this, when https://github.com/runelite/plugin-hub/pull/4107 is merged.