geheur / weapon-animation-replacer

BSD 2-Clause "Simplified" License
4 stars 3 forks source link

Client crash when climbing up the rocks to the crossbow northeast of the GWD entrance. #6

Closed geheur closed 2 years ago

geheur commented 3 years ago

Crashed twice in a row while using rapier xmogged to Scythe of Vitur with (iirc) Scythe of Vitur (all) and Staff (Movement). Don't have the stacktrace anymore. Rip my master clue.

I also witnessed crashes with the rocks you climb coming down from trollheim, but that was back during early development of this plugin and I haven't seen it since.

Annoying that changing animations of all things causes crashes :/. and they're a pita to get a good look into cause they happen in obfuscated client code.

geheur commented 2 years ago

Unable to replicate with my current build. Unsure if it's just a timing issue like #5 though. Replicated pretty quickly on 1.0.1, but it took me 2 tries. stacktrace:

java.lang.ArrayIndexOutOfBoundsException: Index 15 out of bounds for length 8
    at o.fm(o.java:4669)
    at hw.fi(hw.java:4581)
    at mu.fh(mu.java:4559)
    at client.db(client.java:3963)
    at client.f(client.java:1893)
    at at.dr(at.java:380)
    at at.run(at.java:359)
    at java.base/java.lang.Thread.run(Thread.java:832)
Error: o.fm() hw.fi() mu.fh() client.fz() client.i() at.x() | o:4669 hw:4581 mu:4559 client:3963 client:1893 at:380 at:359 Thread:832 | java.lang.ArrayIndexOutOfBoundsException: Index 15 out of bounds for length 8
error_game_crash

It may still be possible to cause this, just less likely because iirc in 1.0.1 I forced pose animations to the values I wanted every client tick, and here I only do it on every game tick. On the other hand, most of those game tick pose animation forces do nothing because the right animation is already set, due to the change in how pose animations are applied (api abex added).

geheur commented 2 years ago

I haven't seen this issue for a long time, and the code that sets pose animations has been changed fundamentally so I doubt this bug still exists.