search

geheur / weapon-animation-replacer

BSD 2-Clause "Simplified" License
4 stars 3 forks source link

Godsword animation bugs #9

Closed Heirem closed 2 years ago

Heirem commented 3 years ago

Godsword idle, walk/run, and defending animations all glitch out.

geheur commented 2 years ago

I'm guessing this is the thing where the framerate or maybe cycle length of the animation your character is actually doing is different from the one the godsword animation override does, so it repeats too early.

This is probably fixable, although I'd have to ask for some extra API to be added.

Heirem commented 2 years ago

Good to hear. Thank you.

On Tue, Jul 20, 2021 at 12:05 PM geheur @.***> wrote:

I'm guessing this is the thing where the framerate or maybe cycle length of the animation your character is actually doing is different from the one the godsword animation override does, so it repeats too early.

This is probably fixable, although I'd have to ask for some extra API to be added.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/geheur/weapon-animation-replacer/issues/9#issuecomment-882943953, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUURN3SV2G5LC5NL3Y74MWLTYS4WHANCNFSM47M6ACMA .

geheur commented 2 years ago

API has been added to runelite that can be used to fix this, possibly also #10, #5, and maybe even #6 if I'm lucky.

Heirem commented 2 years ago

Awesome, thanks!

On Fri, Aug 20, 2021 at 4:57 PM geheur @.***> wrote:

API has been added to runelite that can be used to fix this, possibly also

10 https://github.com/geheur/weapon-animation-replacer/issues/10, #5

https://github.com/geheur/weapon-animation-replacer/issues/5, and maybe even #6 https://github.com/geheur/weapon-animation-replacer/issues/6 if I'm lucky.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/geheur/weapon-animation-replacer/issues/9#issuecomment-902430620, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUURN3RCSACHX4ENCLPCXPTT5XODJANCNFSM47M6ACMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .