search

gehring / fax

MIT License
78 stars 9 forks source link

Hock schittkowski tests #14

Closed manuel-delverme closed 4 years ago

manuel-delverme commented 4 years ago

This commit allows problems from the HockSchittkowski suit to be used as test benchmark for fax.

Please not I'm downloading everything in a temporary folder (e.g. /tmp/) so the tests will require a download every time the system is rebooted

gehring commented 4 years ago

Is there a reason not to keep code to generate them dynamically? Could we instead maintain a single *.py file with all cases implemented explicitly (for example)?

manuel-delverme commented 4 years ago

that's coming up in the next 30 mins :D

On Wed, 29 Apr 2020 at 12:59, gehring notifications@github.com wrote:

Is there a reason not to keep code to generate them dynamically? Could we instead maintain a single *.py file with all cases implemented explicitly (for example)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gehring/fax/pull/14#issuecomment-621369653, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ7ZYRAV23FEVTBTKENZG3RPBTGVANCNFSM4MNLUNKA .

gehring commented 4 years ago

Awesome, thanks!

pierrelux commented 4 years ago

What needs to be done to merge this?

gehring commented 4 years ago

@manuel-delverme Can you address the two unresolved comments from @pierrelux . I could be convinced to leave the test_util.py the way you have it but I would like to avoid those changes to the gitignore. They seem very specific to your own personal set-up.

gehring commented 4 years ago

@manuel-delverme If you haven't already, can you confirm that all the test pass with the most recent changes and then I think we're good to go. Great PR, btw! This contribution is very appreciated.

manuel-delverme commented 4 years ago

There are no new tests for the moment because this PR does not include the solver, the tests will be part of the extra gradient PR coming up next