search

gehrj / vue-country-region-select

A vue country select and a vue region select component that is very easy to use and the region select will update automatically depending on your country selected. They can also be used stand alone.
89 stars 84 forks source link

[BUG] remove-placeholder with top-country breaks the selection of country in country-select #58

Open kjesien opened 3 years ago

kjesien commented 3 years ago

Having remove-placeholder with top-country like this:

<country-select
  v-model="country"
  :country="country"
  top-country="US"
  remove-placeholder
/>

breaks the ability to change the selection. Calling onChange in countries computed property in line 69 causes constant re-selection of top-country.

BTW - computed properties should not have such side effects like emission of events.