gehuangyi20 / ie7-js

Automatically exported from code.google.com/p/ie7-js
0 stars 0 forks source link

Code Review - Quick Frameset Fix. #126

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes on this branch:
This will allow the w=document.body; line to function errorless from within
a frameset.

The change was simply

if(document.body){
w=document.body;
}else{
w=document;
}

(please excuse poor formatting)

Make the error go away, and everything else functions perfectly.

When reviewing my code changes, please focus on the above change.

After the review, I probably won't merge in, because I"m not sure if I have
access to, but if someone gives me it, maybe i will? I don't know.

This was pulled from the latest stable IE8, afaik.

Original issue reported on code.google.com by nphasef...@gmail.com on 11 Nov 2008 at 7:50

Attachments:

GoogleCodeExporter commented 9 years ago
This fix didn't work for me.  I am using this instead:

http://groups.google.com/group/ie7-js/msg/160049c734113532

Original comment by john.lov...@gmail.com on 19 May 2009 at 8:15

GoogleCodeExporter commented 9 years ago
Can you provide a test case instead of a solution. I won't include any code 
without a 
test case to work against.

Original comment by dean.edw...@gmail.com on 11 Feb 2010 at 3:33

GoogleCodeExporter commented 9 years ago
I honestly do not remember the case in which this helped, I'll have to look. 
Sorry!

Original comment by nphasef...@gmail.com on 18 Feb 2010 at 4:44