search

geier / pycarddav

DEPRECATED - use vdirsyncer & khard -- easy to use CLI CardDAV client
http://lostpackets.de/pycarddav
MIT License
98 stars 35 forks source link

Basic fixes for CalendarServer running on OS X (Mountain) Lion Server #51

Closed k8n closed 11 years ago

k8n commented 11 years ago

Multiple issues found related to the specifics of the CalendarServer and an openssl negotiation bug(?).

So far, to make it work with the subj.:

  1. fix requests library digest authentication issue https://github.com/kennethreitz/requests/pull/1242
  2. apply Lukasa's solution for the ssl bug workaround: https://github.com/k8n/pycarddav/commit/3cdece219b6a0a77602714ec3759147b6239a87e
  3. generalize handling of the 'getcontenttype' prop (CalendarServer gives the "text/vcard; charset=utf-8" string variation): https://github.com/k8n/pycarddav/commit/1d8df6479e57b211f46a4c2193b9353d5af42e8b
  4. Fix to initialization issue when working against CalendarServer (propfind infinity error): https://github.com/k8n/pycarddav/commit/2d364766908192ee3bc73fcb4e8b67fc06283883

P.S. an extra commit with a typo fix tagged along (https://github.com/k8n/pycarddav/commit/92b33123342318f5a586ee842762588df9803bb3); sorry.

geier commented 11 years ago

First I'd like to thank you for making pycarddav compatible with CalendarServer.

Then please add yourself to the CONTRIBUTORS.txt file. Also, could you add an example resource for CalendarServer to the config file?

If you do any further work, please do it on the develop branch, that's were most work happens. I hope I find some time to test your path before the weekend.

k8n commented 11 years ago

shall I rebase these changes to the development branch?

geier commented 11 years ago

If you want to, please go ahead, otherwise I'll do it once I find some time to do it

geier commented 11 years ago

@k8n could you rebase all commits but 3cdece2 ("Added option to force use of SSLv3") against the branch develop?

I would like to handle the SSLv3 issue a bit differently, because your solution needs a more recent version of requests than is in current distributions (like Debian stable) and I believe people not familiar with the python ecosystem don't really want to pip install requests. And only when you are hit by this SSL bug you would need to upgrade your request install.

geier commented 11 years ago

ok, looks like all but the SSLv3 bug had been fixed in develop before, therefore I'll close this PR for new