search

geigerzaehler / beets-alternatives

Beets plugin to manage external files
MIT License
93 stars 21 forks source link

Support Python 3 #20

Closed wisp3rwind closed 5 years ago

wisp3rwind commented 5 years ago

As the title says. In particular all paths are now treated with beets' bytestring_path/syspath/displayable_path machinery. I hope I got it all right, this is quite large and I'm not an expert on unicode handling in beets. Types for path storage in the database should not be an issue since Python's sqlite3 library will by default return TEXT columns (as are all flexible attributes) as Unicode objects across all Python versions. Nevertheless, I'd appreciate if someone (...) could upgrade beets from Python 2 to 3 and ensure that not all of the files get added to the alternative collection again (after having taken a backup, of course).

Travis and tox configs are adapted accordingly.

Closes #18

geigerzaehler commented 5 years ago

Could you also add an entry to the “Upcoming” section of the change log?

wisp3rwind commented 5 years ago

Could you also add an entry to the “Upcoming” section of the change log?

Will do :)

discopatrick commented 5 years ago

Just wanted to say a big thank you for making this happen :)