search

geigerzaehler / beets-alternatives

Beets plugin to manage external files
MIT License
93 stars 21 forks source link

Remove beets 1.4.9 and Python 3.9 from CI #56

Closed geigerzaehler closed 4 years ago

geigerzaehler commented 4 years ago

Beets 1.4.9 is not compatible with Python 3.9. We remove it from the CI build matrix.

wisp3rwind commented 4 years ago

I think we should rather do (in fact, I had a branch prepared with this fix, but never pushed it)

diff --git a/.travis.yml b/.travis.yml
index 2caefe1..4ed5c59 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -32,6 +32,9 @@ matrix:
     - env: TOX_ENV=py38-flake8
       python: 3.8

+  allow_failures:
+    python: 3.9-dev
+
 install:
   - "pip install tox"
   - "[ ! -z $COVERAGE ] && pip install coveralls || true"

such that upcoming Python versions never break our builds. Due the bug in question, Travis has been declaring our builds broken for the last few weeks (the bug is fixed in https://github.com/beetbox/beets/pull/3621). Just removing the python-dev + beets_release builds is not sufficient to prevent this, since before the fix, python-dev + beets_master was also broken.