geigi / cozy

🎧 Listen to audio books 📚 on Linux
https://cozy.sh
GNU General Public License v3.0
1.09k stars 84 forks source link

"Stop after current chapter" does not work #747

Open marienvo opened 1 year ago

marienvo commented 1 year ago

Bug/Feature description

When I select "Stop after current chapter" in a .m4b audio book (from OpenAudible), the icon just resets to "no stop/sleep mode" and starts playing the next chapter:

Peek 2022-12-04 17-46

When using the timer, the playback stops as expected though.

Steps to reproduce

Select "Stop after current chapter" and wait for it to not stop when going to the next chapter.

System Information

eMBee commented 1 year ago

i am not sure if this is the right solution, but i came up with this change that seems to fix the problem:

https://gitlab.com/eMBee/cozy/-/commit/e030d3e6cecf3813ad18fc52b44d3979c2664aca

eMBee commented 1 year ago

while my fix works to stop playing at the end of a chapter, the book now shows me a previously incomplete chapter instead of the next one as the next active chapter.

either my patch is incomplete or there is a bug elsewhere.

digitalextremist commented 11 months ago

Saw there was a release and immediately checked the changelog to see if this issue was included. Alas! It is still open! Feeling this one pretty acutely, and eager to see a patch. Love Cozy, send help :)