Two Fixes for Cozy - Githubissues

geigi / cozy

🎧 Listen to audio books 📚 on Linux

https://cozy.sh

GNU General Public License v3.0

1.09k stars 84 forks source link

Two Fixes for Cozy #748

Closed ghost closed 9 months ago

ghost commented 1 year ago

Sorry I didn't split my merge request.

This patches contains two things.

application: Add shortcut for Help

To comply GNOME HIG add shortcut for Help. Source: https://developer.gnome.org/hig/reference/keyboard.html

application: Implement Help Overlay

Help Overlay is GNOME's keyboard shortcuts page. It only lists usable shortcuts, and implementing this future is very easy

geigi commented 1 year ago

Hi @sabriunal sorry for the very late answer. Thanks for your PR! I still have to give your PR a test but so far everything looks good. I only have one suggestion: Cozy uses the python logging framework for logs instead of print. It would be nice to use it also in the translation fix. Otherwise thanks very much for your contribution :)

geigi commented 1 year ago

Fixes #738

ghost commented 1 year ago

The last part removed. It didnt work.