search

geigi / cozy

🎧 Listen to audio books 📚 on Linux
https://cozy.sh
GNU General Public License v3.0
1.09k stars 83 forks source link

Use uniform gaps in book grid #821

Closed rdbende closed 5 months ago

rdbende commented 7 months ago

Fixes #637

grahamvh commented 6 months ago

approve, I can't seem to reproduce the mentioned bug (I don't see a difference on my laptop or phone running master vs this branch). If it helps, I have no objections though. Otherwise:

rdbende commented 6 months ago

I can't seem to reproduce the mentioned bug

It was mostly a problem in the GTK3 version, in the current master it's much better. The only thing really this fixes is where the gaps weren't uniform on every side.

geigi commented 6 months ago

Looks good to me but it looks like we have a conflict with the current master sadly

geigi commented 6 months ago

Should we stick to the Flowbox with this PR?

rdbende commented 6 months ago

Should we stick to the Flowbox with this PR?

Yes, for now, I think we should. The port to GridView will probably be a bigger rework.

geigi commented 6 months ago

I resolved the issue, seems to look fine :)

rdbende commented 6 months ago

Looks good to me but it looks like we have a conflict with the current master sadly

Yeah, that's why I tend to avoid having too many open PRs at once. That said, bow that many of them are merged there's more to come 😄

Anyway, the conflict resolution looks good to me as well. Can you merge it? Sadly I can't, because for that Github needs an approving review on the latest commit from someone other than the PR author.