search

geigi / cozy

🎧 Listen to audio books 📚 on Linux
https://cozy.sh
GNU General Public License v3.0
1.08k stars 83 forks source link

Remove legacy things #904

Closed rdbende closed 2 months ago

rdbende commented 3 months ago

Removed old CI files, no longer used functions and some Flatpak finish-args, that are no longer needed.

@geigi, since this affects some deployment stuff, I'd like you to verify, that it's indeed safe to remove them

--talk-name=org.freedesktop.Notifications

Cozy doesn't send notifications, and GTK will automatically use the desktop portal anyway.

--own-name=org.mpris.MediaPlayer2.Cozy

Flatpak automatically grants access to the org.mpris.MediaPlayer2.<APP-ID> D-Bus name, so this is not needed.

--metadata=X-DConf=migrate-path=/com/github/geigi/cozy/

The migration happened like 6 years ago. This can be removed now.

--env=LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/app/lib

I couldn't find out why exactly this variable was needed, but I suppose it was something with Granite, or libhandy. We no longer compile anything manually, and everything is included in the runtime, so this can be safely removed.

geigi commented 2 months ago

Sorry for the delay... Looks good to me. The only two things that are currently still in use by the deployment workflows are the two bash scripts in the .ci folder. If we keep those we can merge this pr :)

rdbende commented 2 months ago

Ohh, didn't know that. I'll restore them then.