search

geir54 / android-sqrl

android implementation of steve gibsons sqrl authentication
GNU General Public License v3.0
66 stars 16 forks source link

Fix the wrong signed URL. Add the support of vertical bar. #6

Closed nearsyh closed 10 years ago

nearsyh commented 10 years ago

According to the protocol, the signed URL should be same to the authentication query URL.

In the newest version, the protocol support vertical bar.

geir54 commented 10 years ago

Sorry for the long wait. This project has been on hold for a long time. I've started looking at it again today.

Your commit is very messy and it's hard to see what has been changed. I don't want to merge commits like this.

nearsyh commented 10 years ago

Sure. Because I found it had some problems when logging. So I debug a lot and delete some empty lines meanwhile which cause a lot of differences when using diff.

The main problem is that the URL signed by your application is wrong and also the protocol get some updates, like the vertical bar.

geir54 commented 10 years ago

I usually do a clean up before I do a commit. 210 lines added and 180 removed is kind of a mess to go trough. Now an if someone wants the see what happed at some later time.

I think your issue will be fixed in https://github.com/geir54/android-sqrl/pull/8