geist-org / geist-ui

A design system for building modern websites and applications.
https://geist-ui.dev
MIT License
4.34k stars 334 forks source link

Icon colour doesnt change #580

Closed Milo123459 closed 3 years ago

Milo123459 commented 3 years ago

Bug report 🐞

Version & Environment

Expected Behaviour

The behavior I expect is ...

When I do

<Home color="#123" />

it should change colour, but it doesn't. This also applies for sizing. I'm trying to change the size of breadcrumbs and it isn't changing.

Actual results (or Errors)

Colour doesn't change

https://github.com/Milo123459/website/tree/Milo123459/issue97 < code

Milo123459 commented 3 years ago

I also have a question, I need to disable the hover effect in the breadcrumbs when using next link. I set aria-disabled but that doesn't stop the animation. Any ideas?

unix commented 3 years ago

I clone your project and changed the color and everything looks fine. image image

If you are still experiencing this issue, please provide an online example that reproduces the problem. (codesandbox)


Also, if you want to change the CSS effect of the hover, use CSS to override the original style:

nav > a:hover {
  color: inherit;
}
Milo123459 commented 3 years ago

Okay. What about the size of the breadcrumbs not changing?

unix commented 3 years ago

The Breadcrumbs.Item component is not customizable in size; its size depends on the parent Breadcrumbs component, and you can specify the size on the Breadcrumbs to adjust the size of the layout.


If you want to control the size of Breadcrumbs.Item more finely, I recommend using the preview version of Geist UI:

yarn add @geist-ui/react@canary

image

Milo123459 commented 3 years ago

I did and nothing changed?

unix commented 3 years ago

@Milo123459 As you can see, the size property accepts an enumerated value instead of a number or other string, please refer to the official website to modify it:

image

Milo123459 commented 3 years ago

So I have to do:

size="medium"
Milo123459 commented 3 years ago

I did, nothing changed. Can you take a look at my code and see what I did wrong?

unix commented 3 years ago

In your project, everything looks great, do you need to check your code again?

image

Milo123459 commented 3 years ago

I don't think so. In my _app.tsx I have the size property set to medium yet the size doesn't change. I really don't understand

unix commented 3 years ago

I have changed, checked, and previewed your project and everything looks fine, please refer to the above screenshot.

Back to the original question, if you are still troubled by this, please provide an online example so that I can help you figure out why.

Milo123459 commented 3 years ago

I'm not troubled by the original problem, just the size not changing.

Here is a preview deployment, built by Vercel: https://milo123459-h41bfgr6a-salvage.vercel.app/

As you can see, the breadcrumbs size didn't change. Still ridiculously confused.

unix commented 3 years ago

if you are still troubled by this, please provide an online example so that I can help you figure out why.

Milo123459 commented 3 years ago

Well, it works when I try it online but not in my regular project.

Milo123459 commented 3 years ago

In my next project, it doesn't change size. On the code sandbox, it does.

Milo123459 commented 3 years ago

I guess it isn't a bug, but would you mind helping me out / figuring out why it doesn't work?