geist-org / geist-ui

A design system for building modern websites and applications.
https://geist-ui.dev
MIT License
4.33k stars 334 forks source link

No Size Prop for components #593

Closed VioletBuse closed 3 years ago

VioletBuse commented 3 years ago

Bug report 🐞

There is no size prop for components. I use typescript, and found that there is an error when trying to set size. I looked at the definition, and found that it doesnt exist in the type declaration.

Version & Environment

Expected Behaviour

The behavior I expect is that there is the ability to set size

Actual results (or Errors)

I got an error:

interface Props {
    type?: ButtonTypes;
    ghost?: boolean;
    loading?: boolean;
    shadow?: boolean;
    auto?: boolean;
    effect?: boolean;
    disabled?: boolean;
    htmlType?: React.ButtonHTMLAttributes<any>['type'];
    icon?: React.ReactNode;
    iconRight?: React.ReactNode;
    onClick?: React.MouseEventHandler<HTMLButtonElement>;
    className?: string;
}

As you can see, no size prop. This is for the Button, but this issue exists for all components that should accept a size prop.

ofekashery commented 3 years ago

Please see #586.