search

geist-org / geist-ui

A design system for building modern websites and applications.
https://geist-ui.dev
MIT License
4.35k stars 335 forks source link

typo: table component #611

Closed moatorres closed 3 years ago

moatorres commented 3 years ago

Bug report 🐞

Version & Environment

Expected Behaviour

Components' displayName should be 'Geist<component-name>'

Actual results (or Errors)

No errors, just small typos:

https://github.com/geist-org/react/blob/b6f6cda90f00aba475b114dd02ad39efd6470321/components/table/table-column.tsx#L51

https://github.com/geist-org/react/blob/299f7741ead460e1eb65a7c112060af21a324f0e/components/select/select-input.tsx#L55

https://github.com/geist-org/react/blob/299f7741ead460e1eb65a7c112060af21a324f0e/components/tree/tree-folder-icon.tsx#L43

https://github.com/geist-org/react/blob/299f7741ead460e1eb65a7c112060af21a324f0e/components/tabs/tabs-item.tsx#L110

https://github.com/geist-org/react/blob/299f7741ead460e1eb65a7c112060af21a324f0e/components/tooltip/tooltip.tsx#L133

Turns out that this is the correct syntax (below). Also not sure if this , comma should be there?

https://github.com/geist-org/react/blob/b6f6cda90f00aba475b114dd02ad39efd6470321/components/table/table-head.tsx#L18

moatorres commented 3 years ago

I guess we can always try, right? Opened PR #612 to fix that, if it's not overkill.

moatorres commented 3 years ago

The PR #612 fixes those