gekoke / magit-file-icons

File icons for Magit
GNU General Public License v3.0
30 stars 6 forks source link

`magit-file-files-mode` enable error on Emacs startup #1

Closed stardiviner closed 3 months ago

stardiviner commented 3 months ago

After installed this package, I restart Emacs, got bellowing error.

Here is the backtrace show at bellowing:

Debugger entered--Lisp error: (magit-outside-git-repo . "~/")
  signal(magit-outside-git-repo "~/")
  magit--not-inside-repository-error()
  magit--toplevel-safe()
  magit-get-mode-buffer(magit-status-mode)
  magit-refresh()
  magit-file-icons-mode(1)
  (progn (magit-file-icons-mode 1) t)
  (condition-case err (progn (magit-file-icons-mode 1) t) ((debug error) (funcall use-package--warning534 :config err)))
  (if (not (require 'magit-file-icons nil t)) (display-warning 'use-package (format "Cannot load %s" 'magit-file-icons) :error) (condition-case err (progn (magit-file-icons-mode 1) t) ((debug error) (funcall use-package--warning534 :config err))))
  #f(lambda () :dynbind (if (not (require 'magit-file-icons nil t)) (display-warning 'use-package (format "Cannot load %s" 'magit-file-icons) :error) (condition-case err (progn (magit-file-icons-mode 1) t) ((debug error) (funcall use-package--warning534 :config err)))))()
  eval-after-load(magit #f(lambda () :dynbind (if (not (require 'magit-file-icons nil t)) (display-warning 'use-package (format "Cannot load %s" 'magit-file-icons) :error) (condition-case err (progn (magit-file-icons-mode 1) t) ((debug error) (funcall use-package--warning534 :config err))))))
  (condition-case err (eval-after-load 'magit #'(lambda nil (if (not (require 'magit-file-icons nil t)) (display-warning 'use-package (format "Cannot load %s" 'magit-file-icons) :error) (condition-case err (progn (magit-file-icons-mode 1) t) ((debug error) (funcall use-package--warning534 :config err)))))) ((debug error) (funcall use-package--warning534 :catch err)))
  eval-buffer(#<buffer  *load*-853980> nil "/Users/stardiviner/.config/emacs/init/programming/vcs/init-prog-vcs-git.el" nil t)  ; Reading at buffer position 7432
  load-with-code-conversion("/Users/stardiviner/.config/emacs/init/programming/vcs/init-prog-vcs-git.el" "/Users/stardiviner/.config/emacs/init/programming/vcs/init-prog-vcs-git.el" nil nil)
  #<subr load>("init-prog-vcs-git" nil nil nil nil)
  ad-Advice-load(#<subr load> "init-prog-vcs-git")
  apply(ad-Advice-load #<subr load> "init-prog-vcs-git")
  load("init-prog-vcs-git")
  eval-buffer(#<buffer  *load*-953716> nil "/Users/stardiviner/.config/emacs/init/programming/vcs/init-prog-vcs.el" nil t)  ; Reading at buffer position 459
  load-with-code-conversion("/Users/stardiviner/.config/emacs/init/programming/vcs/init-prog-vcs.el" "/Users/stardiviner/.config/emacs/init/programming/vcs/init-prog-vcs.el" nil nil)
  #<subr load>("init-prog-vcs" nil nil nil nil)
  ad-Advice-load(#<subr load> "init-prog-vcs")
  apply(ad-Advice-load #<subr load> "init-prog-vcs")
  load("init-prog-vcs")
  eval-buffer(#<buffer  *load*> nil "/Users/stardiviner/.config/emacs/init.el" nil t)  ; Reading at buffer position 6723
  load-with-code-conversion("/Users/stardiviner/.config/emacs/init.el" "/Users/stardiviner/.config/emacs/init.el" t t)
  load("/Users/stardiviner/.config/emacs/init" noerror nomessage)
  #f(compiled-function () #<bytecode 0x12e013edbcfb9591>)()
  startup--load-user-init-file(#f(compiled-function () #<bytecode 0x13d0b598f0f8bb12>) #f(compiled-function () #<bytecode -0x15951949e52a4b4f>) t)
  command-line()
  normal-top-level()

Here is my config:

(use-package magit-file-icons
  :ensure t
  :after magit
  :config (magit-file-icons-mode 1))
gekoke commented 3 months ago

Let me know if https://github.com/gekoke/magit-file-icons/commit/cb2eb65fb4bc3ee59d73d430675280c310be02ef is better. I've removed the call to magit-refresh since it might not be worth the trouble

stardiviner commented 3 months ago

Thanks for quick patch! Fixed now