search

gekoke / magit-file-icons

File icons for Magit
GNU General Public License v3.0
30 stars 6 forks source link

Version 2.0.0: Error "Resolving ‘magit-insert-files-1’ template failed -- Cannot find definition" #8

Closed dunmaksim closed 2 months ago

dunmaksim commented 2 months ago

Hello!

Today me update magit-file-icons to version 2.0.0, and now I see this message on minibuffer and *Warnings* buffer:

Error (use-package): magit-file-icons/:config: Resolving ‘magit-insert-files-1’ template failed -- Cannot find definition

My settings:

(use-package magit-file-icons
  :ensure t
  :after magit
  :config
  (magit-file-icons-mode 1))

Emacs 29.3

gekoke commented 2 months ago

Hi!

v2.0.0 is a major version bump in order to accommodate breaking changes to Magit's internals (see #7). If you're not using a very recent version of Magit, this error is expected.

Your options include: 1) updating magit to at least MELPA version magit-20240624 2) using magit-file-icons at v1.x.x

magit-file-icons relies on the internal structure of the magit package looking a certain way, so it will break if any of that ever changes (which will, hopefully, be infrequently)

Let me know if this helps.

dunmaksim commented 2 months ago

Yes, that works. Thank you!