gekware / minecraft-server-hibernation

Autostart and stop minecraft-server when players join/leave
GNU General Public License v3.0
389 stars 38 forks source link

MSH starts server while players are already playing (If Waterfall Proyx is used) #144

Closed BolverBlitz closed 2 years ago

BolverBlitz commented 2 years ago

Current Behavior (šŸ› Bug)

Only seen this with Waterfall proxy.

If a player joins a MSH server, MSH will start minecraft. Then if another player tryes to join, MSH will forward him to minecraft server running but also starts a new miencraft server that will fail because the port is used already

Log: (Debug Lv 3) grafik

Expected Behavior

DonĀ“t start the minecraft server when its already runnning

Steps to Reproduce

Join a msh server 2 times.

MSH-Version

2.4.6

Operating system

Debian

Minecraft Version

1.18.2

Minecraft Server Software

Paper

Is there an existing issue for this?

gekigek99 commented 2 years ago

The server starting a second time bug was already solved with issue #108.

Is it urgent to be fixed also in dev or can you wait the merge from branch feature/ms-suspend?

The issue is now... Why does msh tryes to launch the server even tho it's already online?

Can you set the log to 4 (bytenerd)? So i see what is the join request...

gekigek99 commented 2 years ago

@BolverBlitz how do i set up a waterfall proxy to test it?

BolverBlitz commented 2 years ago

Create Bungeecord and download Waterfall https://papermc.io/downloads#Waterfall

gekigek99 commented 2 years ago

immagine

seems to be solved now, probably fixed in 6cc145c7387707144ec0ac4eca8d741812a328e1