search

gekware / minecraft-server-hibernation

Autostart and stop minecraft-server when players join/leave
GNU General Public License v3.0
389 stars 38 forks source link

Server icon bugged #182

Closed Chris6ix closed 1 year ago

Chris6ix commented 1 year ago

Current Behavior (🐛 Bug)

At first, the minecraft server icon was fine and msh had the snowy dirt block as an icon, but now msh has replaced the minecraft server icon with a sun and the msh icon with 4 small images of the moon next to the snowy dirt block

2022-12-21_17 00 15

Expected Behavior

Not change the icon of the mc server and display the snowy dirt block for msh.

Steps to Reproduce

Start msh and start server?

MSH Logs

Not sure if it is related as it also happened before this log, but now it's getting warnings and errors when I spam refresh from my minecraft client: image

MSH-Version

2.4.10

Operating system

Windows 10

Minecraft Version

1.19.3

Minecraft Server Software

Paper

Is there an existing issue for this?

gekigek99 commented 1 year ago

I am aware of this bug.

But I didn't find any msh related cause and think its just caused by a graphical error on client side.

If you have any idea/suggestion on how to solve it I would gladly listen to it.

Chris6ix commented 1 year ago

I am aware of this bug.

But I didn't find any msh related cause and think its just caused by a graphical error on client side.

If you have any idea/suggestion on how to solve it I would gladly listen to it.

I'm not a programmer, so I can't tell you exactly how to fix that, but my suggestion would be to just stop msh from modifying icons overall. I don't really see the benefit in that, so I would just make msh display the snowy dirt block all the time and leave the mc server's be.

gekigek99 commented 1 year ago

but msh is not modifying anything if you don't add a personalized image. msh uses the default pic without modifying it.

If you restart minecraft client it might actually be fixed.

Chris6ix commented 1 year ago

Hmm...that's weird...how does this issue happen then if it "uses the default pic without modifying it"? Because I have never seen that before i started using msh...

gekigek99 commented 1 year ago

yeah Idk months ago I tested it looking at the bytes exchanged and coudnt find a correlation.

Proabably it has to do with msh sending a "static" image not adapted to the situation and the client to save bandwidth stores it wrong until it decides to reload it.

Chris6ix commented 1 year ago

Oh, alright I'm closing this issue then, so you can pin it. That way people that have that bug know it's already known and can't really be fixed.