gekware / minecraft-server-hibernation

Autostart and stop minecraft-server when players join/leave
GNU General Public License v3.0
379 stars 37 forks source link

Stopping msh with `msh exit` while ssh'ed prevents text input in cli. #208

Closed Nannk closed 1 year ago

Nannk commented 1 year ago

Current Behavior (🐛 Bug)

connected to the server through ssh: msh is running

execute msh exit

(further testing is required, ill do it asap and update the issue)

if msh is exited with Ctrl-C, cli input works as expected.

This issue happened in dev branch version of msh with latest commit being https://github.com/gekware/minecraft-server-hibernation/commit/a1640628e760c3ec9ebaa12cf44a7334f35609f2

Expected Behavior

Steps to Reproduce

suppose msh is already running:

  • Stop msh "gracefully" with msh exit command
  • try to type something in the cli.

MSH Logs

2023/02/12 23:31:52 [byte      ] client --> msh: [1 0]
2023/02/12 23:31:52 [byte      ] client --> msh: [9 1 0 0 0 0 0 0 192 197]
2023/02/12 23:31:52 [byte      ] msh --> client: [9 1 0 0 0 0 0 0 192 197]
2023/02/12 23:31:52 [info  ≡   ] closing connection for: IPPROTECTED
2023/02/12 23:31:52 [byte      ] client --> msh: [9 1 0 0 0 0 0 0 192 198]
2023/02/12 23:31:52 [byte      ] msh --> client: [9 1 0 0 0 0 0 0 192 198]
2023/02/12 23:31:52 [info  ≡   ] closing connection for: IPPROTECTED
» msh exit
2023/02/12 23:32:02 [info  ≡   ] user input: [msh exit]
2023/02/12 23:32:02 [info  ≡   ] executing ms force freeze...
2023/02/12 23:32:02 [warn  ≡   ] FreezeMS: minecraft server is offline [00f209]
2023/02/12 23:32:02 [info  ≡≡≡≡] issuing msh termination
2023/02/12 23:32:02 [info  ≡≡≡ ] received signal: interrupt
2023/02/12 23:32:02 [info  ≡   ] executing ms force freeze...
2023/02/12 23:32:02 [warn  ≡   ] FreezeMS: minecraft server is offline [00f209]
2023/02/12 23:32:02 [info  ≡   ] sending api2 request
2023/02/12 23:32:02 [byte      ] msh --> mshc: {"prot-v":2,"msh":{"msh-v":"v2.4.12","id":"3db687f971d3aa3825f283f7d62fa1934b09f05c","uptime":25,"allow-suspend":false,"sgm":{"preterm":true,"seconds":25,"seconds-hibe":25,"play-second-sum":0,"cpu-usage":0.613394072416989,"mem-usage":0.018799619227647783}},"machine":{"os":"linux","arch":"amd64","java-v":"openjdk 19.0.1 2022-10-18","cpu-model":"Intel(R) Xeon(R) CPU E5-2690 v2 @ 3.00GHz","cpu-vendor":"GenuineIntel","cores-msh":20,"cores-sys":20,"mem":67401482240},"server":{"uptime":-1,"ms-v":"","ms-prot":-1}}
2023/02/12 23:32:03 [info  ≡   ] minecraft server terminal already exited (minecraft server is offline)
2023/02/12 23:32:03 [info  ≡≡≡≡] exiting msh
» minecraft@nannkserver:~/build/minecraft-server-hibernation$ 

MSH-Version

2.4.12

Operating system

Ubuntu 22.04.1 LTS (GNU/Linux 5.15.0-60-generic x86_64)

System architecture?

AMD64

Minecraft Version

1.19.3

Minecraft Server Software?

Fabric

Is there an existing issue for this?

Nannk commented 1 year ago

Hm looks like its a problem with ssh and not msh. I can execute commands , the text is just not showing up un the cli.