gekware / minecraft-server-hibernation

Autostart and stop minecraft-server when players join/leave
GNU General Public License v3.0
377 stars 36 forks source link

Conflict on stop detection #255

Open Br31zh opened 10 months ago

Br31zh commented 10 months ago

Current Behavior (🐛 Bug)

When this line is printed in the logs by a mod (Create Track Map) : [01:07:56] [Server thread/INFO]: Stopping Create Track Map server, MSH consider that the server is stopping: 2023/10/22 01:07:56.580 [info ≡≡≡ ] MINECRAFT SERVER IS STOPPING!.

Expected Behavior

Just ignoring this log message.

Steps to Reproduce

On a server, you Need Fabric, Create, Create Track Map, Fabric API and Kotlin libraries. Or any mod that make this kind of log message.

MSH Logs

2023/10/22 01:07:56.580 [serv  ≡≡  ] [01:07:56] [Server thread/INFO]: Stopping Create Track Map server
2023/10/22 01:07:56.580 [info  ≡≡≡ ] MINECRAFT SERVER IS STOPPING!
2023/10/22 01:07:57.600 [serv  ≡≡  ] [01:07:57] [DefaultDispatcher-worker-4/INFO]: Autoreload is disabled because the development mode is off.
2023/10/22 01:07:57.603 [serv  ≡≡  ] [01:07:57] [DefaultDispatcher-worker-4/INFO]: Application started in 0.004 seconds.
2023/10/22 01:07:57.605 [serv  ≡≡  ] [01:07:57] [DefaultDispatcher-worker-5/INFO]: Responding at http://0.0.0.0:3876
2023/10/22 01:07:57.605 [serv  ≡≡  ] [01:07:57] [Server thread/INFO]: Started Create Track Map server on port 3876
2023/10/22 01:45:17.686 [info  ≡≡≡ ] A CLIENT DISCONNECTED FROM THE SERVER! (join req) - 1 active connections
2023/10/22 01:45:17.710 [serv  ≡≡  ] [01:45:17] [Server thread/INFO]: XXXXXXX lost connection: Disconnected
2023/10/22 01:45:17.711 [serv  ≡≡  ] [01:45:17] [Server thread/INFO]: XXXXXXX left the game
2023/10/22 01:45:27.695 [info  ≡≡≡ ] performing scheduled ms soft freeze
2023/10/22 01:45:27.695 [info  ≡≡≡ ] EXECUTED PROCESS TREE RESUME!
Starting Minecraft Server World Backup...
2023/10/22 02:00:00.095 [error ≡≡≡≡] GetInput: minecraft server is not online (try "msh start") [00f201]

There was two players before the disconnection. So there is still one online, but MSH consider that the server isn’t online (when it is). My backup process send a command to MSH (to forward it to the server) but MSH refuse since the server isn’t online anymore from its point of view.

MSH-Version

2.5.0

MSH-Commit

0876091

Operating system

Arch Linux

System architecture?

AMD64

Minecraft Version

1.20.1 Quilt

Minecraft Server Software?

Other (Add to Minecraft Version)

Is there an existing issue for this?