search

gelatodigital / gelato-network

V1 implementation of Gelato Network
https://gelato.network/
MIT License
232 stars 29 forks source link

GelatoProviders.isProviderLiquid parameter naming #251

Open gitpusha opened 4 years ago

gitpusha commented 4 years ago

CanExec makes use of it: https://github.com/gelatodigital/gelato-network/blob/e57ce87be57f21f2560f517af4902fdf80f4fad8/contracts/gelato_core/GelatoCore.sol#L176

Problem: SelfProviders are not taken into account by isProviderLiquid https://github.com/gelatodigital/gelato-network/blob/e57ce87be57f21f2560f517af4902fdf80f4fad8/contracts/gelato_core/GelatoProviders.sol#L310

gitpusha commented 4 years ago

I got confused due to parameter naming - we should change to

    function isProviderLiquid(
        address _provider,
        uint256 _gasLimit,
        uint256 _gasPriceCeil
    )