gelic-idealab / impress

Education Research domain module for the Komodo platform
3 stars 2 forks source link

Komodo v0.5.6 Integrations #13

Closed parseccentric closed 2 years ago

parseccentric commented 2 years ago

Komodo v0.5.6 Integrations

Target release: v0.1.2 alpha

Capture Button in Instructor Menu

A new instructor-only menu is available in the settings panel (in spectator mode only, so that VR users do not accidentally activate it).

It has a single button that can start and stop captures for the current session.

The button, for the time being, does not synchronize its state to other users.

Please see https://github.com/gelic-idealab/komodo-unity/pull/93 for a more detailed description of the new changes.

Bug fix: Color Picker Initialization

This bug has not been present in Impress lately, but it does occur whenever trying to directly integrate the KomodoCore package into the Impress project. It has been manually fixed this time, and the changes will hopefully be upstreamed to komodo-unity soon. For convenience, the bug is detailed below.

Type of change

How Has This Been Tested?

Actions to take:

  1. Open the Create menu
  2. Press the Draw button
  3. Start drawing

Expected result:

  1. Color of the stroke matches the selected color

Buggy result:

  1. Color of the stroke is either black or white
  2. It's required to close and re-open the draw tab to restore the proper color selection

REPLACE ME: any relevant details for your test configuration

[Duplicate all of the above for each distinct feature / bug fix / etc.]


Test Configuration

Checklist:

Modified from this article: Phillip Johnston, “A GitHub Pull Request Template for Your Projects - Embedded Artistry,” Embedded Artistry, Aug. 04, 2017. https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ (accessed Jul. 22, 2021).

parseccentric commented 2 years ago

Changes have been included in https://github.com/gelic-idealab/impress/pull/18