This bug has not been present in Impress lately, but it does occur whenever trying to directly integrate the KomodoCore package into the Impress project. It has been manually fixed this time, and the changes will hopefully be upstreamed to komodo-unity soon. For convenience, the bug is detailed below.
Type of change
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Testing
[ ] Change that requires a documentation update
How Has This Been Tested?
Actions to take:
Open the Create menu
Press the Draw button
Start drawing
Expected result:
Color of the stroke matches the selected color
Buggy result:
Color of the stroke is either black or white
It's required to close and re-open the draw tab to restore the proper color selection
REPLACE ME: any relevant details for your test configuration
[x] Manual Test
[ ] Unit Test
[ ] Integration / End-to-End Test
[Duplicate all of the above for each distinct feature / bug fix / etc.]
Test Configuration
REPLACE ME: Browser vendor and version: e.g., Chrome Version 91.0.4472.164 (Official Build) (64-bit)
REPLACE ME: VR Device and OS version: e.g., Oculus Quest v29
[ ] PC VR (Link / AirLink)
[ ] Standalone
Checklist:
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas that are not self-documenting
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] My changes have no unnecessary logging
[ ] I have added tests that prove my fix is effective or that my feature works, for sufficiently complex features
[ ] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] Sensitive info like tokens, secrets, and passwords have been removed before submitting
Komodo v0.5.6 Integrations
Target release: v0.1.2 alpha
Capture Button in Instructor Menu
A new instructor-only menu is available in the settings panel (in spectator mode only, so that VR users do not accidentally activate it).
It has a single button that can start and stop captures for the current session.
The button, for the time being, does not synchronize its state to other users.
Please see https://github.com/gelic-idealab/komodo-unity/pull/93 for a more detailed description of the new changes.
Bug fix: Color Picker Initialization
This bug has not been present in Impress lately, but it does occur whenever trying to directly integrate the KomodoCore package into the Impress project. It has been manually fixed this time, and the changes will hopefully be upstreamed to komodo-unity soon. For convenience, the bug is detailed below.
Type of change
How Has This Been Tested?
Actions to take:
Expected result:
Buggy result:
REPLACE ME: any relevant details for your test configuration
[Duplicate all of the above for each distinct feature / bug fix / etc.]
Test Configuration
Checklist:
New and existing unit tests pass locally with my changesModified from this article: Phillip Johnston, “A GitHub Pull Request Template for Your Projects - Embedded Artistry,” Embedded Artistry, Aug. 04, 2017. https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ (accessed Jul. 22, 2021).