search

gelic-idealab / komodo-unity

Unity VR client for the Komodo XR platform
5 stars 3 forks source link

Wait until Unity and scene are fully initialized before connecting to relay #29

Closed parseccentric closed 3 years ago

parseccentric commented 3 years ago

See https://gitlab.engr.illinois.edu/dev-studio/komodo/komodo_unity/-/issues/105 .

davtamay commented 3 years ago

This ended up being due to loading times of clients, if it took longer than 5 seconds the connection will be dropped. @wallacerob Did a fix on increasing default time to 30.

Option Default valueDescription pingTimeout 5000 how many ms without a pong packet to consider the connection closed

"theory is that if we increase this from 5 seconds to like 30 it might fix the current issue"

wallacerob commented 3 years ago

yes, this is hotfixed with the relay hack described by @davtamay . Real fix will be waiting to initialize socket connection until after we are finished doing our local Unity setup.

wallacerob commented 3 years ago

we should probably change this issue to "Wait until Unity and scene are fully initialized before connecting to relay" or some such.

parseccentric commented 3 years ago

Previously entitled "State catch-up and network relay sync possibly breaks down after multi-client bump"

wallacerob commented 3 years ago

https://github.com/gelic-idealab/komodo-unity/commit/0caa45992e7c5d975be3f78a498106105340b131