CPP & relax bounds to build/test also from lts12 back to lts9

gelisam / hawk

Haskell text processor for the command-line

Apache License 2.0

361 stars 20 forks source link

CPP & relax bounds to build/test also from lts12 back to lts9 #256

Closed juhp closed 3 years ago

juhp commented 3 years ago

exclude 8.6 (lts14 & 13) due to MonadFail issue

(lts8 (7.10) also builds but its cabal-doctest is too old)

Tested with stack-all:

stack-all -o lts16 build --test is still fine
stack-all lts14 lts13 build rejected as expected
stack-all -n lts12 -o lts9 build --test now passes too

gelisam commented 3 years ago

stack-all lts14 lts13 build rejected as expected

"rejected" in the sense that a build plan is not found, or that a build plan is (incorrectly) found but then the build fails? I would have expected a range for base which excludes the versions of ghc with which we know we are incompatible.

juhp commented 3 years ago

Not like ghc (>8.0 && <8.5) || >8.8 ?

Correct, no build plan is found (In this case stack-all lts14 is just stack --resolver lts-14 build).

But I think you are probably right that doing it for base instead is more correct.

gelisam commented 3 years ago

Ah! putting the bounds on ghc sounds easier; I am used to putting the bounds on base as a proxy for putting them on ghc, but that's only because most packages don't depend on ghc directly. since we do depend on ghc, we can do either!