search

gelisam / klister

an implementation of stuck macros
BSD 3-Clause "New" or "Revised" License
132 stars 11 forks source link

investigate macos test issues #131

Closed gelisam closed 3 years ago

gelisam commented 3 years ago

I don't have a solution yet, but the error only occurs on CI, so I have to open a PR in order to investigate further.

gelisam commented 3 years ago

I expected the test to fail with a clearer error message (comparing the Show representation of the strings instead of the string themselves, to be able to see any differences in the unicode or newline encoding), but instead the test passed! Did I accidentally find a fix, or is this a sporadic failure?

gelisam commented 3 years ago

Nope, it's consistent: the test fails with goldenVsString, and passes with my reimplementation. I don't know what the difference is, but I guess we should keep mine!

gelisam commented 3 years ago

oops, I forgot to revert temporarily focus on the failing macOS test, I'll do it directly on master