search

gelisam / klister

an implementation of stuck macros
BSD 3-Clause "New" or "Revised" License
129 stars 11 forks source link

expander: add Expected/Actual newtypes #200

Closed doyougnu closed 1 year ago

doyougnu commented 1 year ago

fixes: #151

Hi @gelisam !

We don't know each other but I was talking to @david-christiansen and he mentioned this project. It seems extremely interesting and I would like to contribute. So I thought this would be a dead simple PR and issue to close out. Please let me know if there is any edits you'd like, I am more than happy to do them. For example, I can imagine unExpected expected could be confusing, so we could use getExpected for the projection instead.

gelisam commented 1 year ago

Nice, thanks for contributing! David and I happen to have a meeting about Klister in a few hours, I'll send you an invite, please join if you have time and we'll show you around the code!

edit: the meeting has been moved to next week

doyougnu commented 1 year ago

Nice, thanks for contributing! David and I happen to have a meeting about Klister in a few hours, I'll send you an invite, please join if you have time and we'll show you around the code!

edit: the meeting has been moved to next week

Sounds great to me as I intend to do many more contributions. Is there a better avenue to chat about Klister than GH PRs and issue lists?

gelisam commented 1 year ago

Is there a better avenue to chat about Klister than GH PRs and issue lists?

The team is very small, so we don't yet have a mailing list; feel free to email David and I.

The way we usually collaborate is indeed via issues and PRs (note the existence of the generic "discussion" label for issues which don't fit into the other categories; we use issues for a lot more than just bug reports), followed by a discussion on our monthly meeting (I sent you an invite), followed by the creation of a few extra issues to reflect the discussion's decisions.

If you are eager to jump in and can't wait for our next meeting, you and I could also schedule a video call via email.

doyougnu commented 1 year ago

It wasn't just requireDeclarationCat which was swapped, it was every single call sites. That is, the constant value is the expected one, while the variable we get from the pattern match, typically called other, is the actual value we receive.

aha! Of course. This is now a tomorrow task. Talk to you then.

doyougnu commented 1 year ago

All good now!

let me manually squash to remove the noise in the commit history.

EDIT: Done

doyougnu commented 1 year ago

Ack I've become too used to gitlab. I've set my primary email in github so that my name doesn't show up as both doyougnu and Jeffrey Young in the commit log.