search

gelisam / klister

an implementation of stuck macros
BSD 3-Clause "New" or "Revised" License
128 stars 11 forks source link

A CEK Evaluator #223

Open doyougnu opened 5 months ago

doyougnu commented 5 months ago

Still a draft but all but one test is passing.

TODOs:

gelisam commented 5 months ago

I'm experimenting with an AI-based code review tool called "CodeRabbit", please let me know if its comments are annoying and I'll turn it off.

coderabbitai[bot] commented 4 months ago

[!WARNING]

Rate limit exceeded

@doyougnu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 50 minutes and 39 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 906a85e62f2e47ea031239970351e6ed378dd7d6 and d3cca7a657939953a224e0fec847bab9494842ef.

Walkthrough

The recent updates enhance the evaluation process by introducing a new evaluateIn function, restructuring the Evaluator module with new data types and functions, and refining error handling. These changes improve the CEK interpreter's logic and control flow. Additionally, the Expander module sees function renaming and refactoring, while the Pretty module adds a new error case for better error messaging.

Changes

Files Change Summaries
repl/Main.hs Replaced runExceptT and runReaderT with evaluateIn; updated error handling and result printing logic.
src/Evaluator.hs Added language extensions, new data types (EvalResult, Kont, EState), and multiple new functions for CEK interpreter logic.
src/Expander.hs, .../Monad.hs Renamed expandEval to evalInCurrentPhase; refactored functions and adjusted error handling.
src/Pretty.hs Added error case for EvalErrorIdent in Pretty VarInfo EvalError instance.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant REPL
    participant Evaluator
    participant Expander

    User->>REPL: Enter expression
    REPL->>Evaluator: evaluateIn(expression)
    Evaluator->>Expander: evalInCurrentPhase(expression)
    Expander-->>Evaluator: Expanded expression
    Evaluator-->>REPL: Evaluated result
    REPL-->>User: Display result

Poem

🐇 In the realm of code so grand,
A rabbit hops with changes planned.
Evaluations now refined,
Errors clearer, functions aligned.
With evaluateIn we stride,
Through logic’s flow, we now glide.
Hopping forward, side by side. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > :bangbang: **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
doyougnu commented 4 months ago

Should be ready for review now. Its a bit slower than what we had. Why is that? Well:

$  perf stat -- cabal test --test-show-details=streaming
 Performance counter stats for 'cabal test --test-show-details=streaming':

         18,349.25 msec task-clock:u                     #    0.996 CPUs utilized          
                 0      context-switches:u               #    0.000 /sec                   
                 0      cpu-migrations:u                 #    0.000 /sec                   
           717,329      page-faults:u                    #   39.093 K/sec                  
    77,585,648,085      cycles:u                         #    4.228 GHz                    
   169,000,946,915      instructions:u                   #    2.18  insn per cycle         
    36,205,500,147      branches:u                       #    1.973 G/sec                  
       497,651,939      branch-misses:u                  #    1.37% of all branches        
   387,384,692,920      slots:u                          #   21.112 G/sec                  
   111,272,326,760      topdown-retiring:u               #     19.8% Retiring              
   335,353,029,163      topdown-bad-spec:u               #     59.7% Bad Speculation       
    75,804,429,827      topdown-fe-bound:u               #     13.5% Frontend Bound        
    39,530,241,508      topdown-be-bound:u               #      7.0% Backend Bound         

      18.416893454 seconds time elapsed

      17.278805000 seconds user
       1.124952000 seconds sys

Because it destroys the branch predictor in my laptop! {59.7% bad speculation)