search

gelldur / EventBus

A lightweight and very fast event bus / event framework for C++17
Apache License 2.0
371 stars 81 forks source link

Upgrade to catch2 version 3.2.0 #45

Open joakimwennergren opened 2 years ago

joakimwennergren commented 2 years ago

Describe the bug Not really a bug but an improvement: upgrade catch2 depdency to look for 3.2.0 latest stable.

To Reproduce cmake add_subdirectory and get warning that catch2 version 2.10 is needed when recently running brew install catch2 which will install 3.2.0 stable.

Expected behavior get no error/warning.

Build:

Additional context find_package(Catch2 3.2.0 REQUIRED) in CmakeLists.txt should do it.

gelldur commented 2 years ago

Thank you, I will upgrade but need to fix CI pipeline first. For now you may just build without tests.

option(ENABLE_TEST "Enable test" ON)

I may consider to turn it off by default. What do you think? Normally when someone uses lib want fast and easy build I think.

joakimwennergren commented 2 years ago

Thank you, I will upgrade but need to fix CI pipeline first. For now you may just build without tests.

option(ENABLE_TEST "Enable test" ON)

I may consider to turn it off by default. What do you think? Normally when someone uses lib want fast and easy build I think.

Yes i also think turning it off by default is the way to go.