gelly-gmod / gelly

Library to integrate fluids into a game engine
GNU General Public License v3.0
19 stars 3 forks source link

[TICKET]: Fix blood mod damage type logic #59

Closed Derpius closed 2 months ago

Derpius commented 3 months ago

Context

Scope

Acceptance Criteria

Other

We should consider whether damage types are the way to go here from a product perspective

I think they should be a fallback, with the primary configuration method using the name of the weapon as the key in a lookup table - Both a small pistol and HMG may deal DMG_BULLET, but we probably want different configs for each

yogwoggf commented 3 months ago

For bookkeeping, #59 could be a solution for this ticket, but it needs extensive code review

Derpius commented 3 months ago

59 is this issue’s ref, you mean #69

Also you should be able to edit other people’s pr descs to include closing tags like “Resolves” - I’ve done this now