Closed Derpius closed 2 months ago
For bookkeeping, #59 could be a solution for this ticket, but it needs extensive code review
59 is this issue’s ref, you mean #69
Also you should be able to edit other people’s pr descs to include closing tags like “Resolves” - I’ve done this now
Context
DMG
enum (with some being combinations of various flags)DMG
enum is used as a bitflag - i.e. a LUT key ofDMG_BULLET
will only match on a damage event with that single field set, and nothing elseScope
damageFlags
- Same as the current key (this should be both single enum values andbit.bor
'd combinations of flagsipairs
andbit.band
the damage's type with thedamageFlags
propertyAcceptance Criteria
bit.band(damageType, preset.damageFlags) ~= 0
istrue
getting used/data
directory (facilitating future work to share or edit them in-game)Other
We should consider whether damage types are the way to go here from a product perspective
I think they should be a fallback, with the primary configuration method using the name of the weapon as the key in a lookup table - Both a small pistol and HMG may deal
DMG_BULLET
, but we probably want different configs for each