search

gelstudios / gitfiti

abusing github commit history for the lulz
MIT License
8.07k stars 1.12k forks source link

added heart as an image option #52

Closed deadbaed closed 3 years ago

deadbaed commented 6 years ago

let me know if i did something wrong

i tested and it works.

deadbaed commented 6 years ago

forgot to add a screenshot, my bad
screenshot from 2018-01-20 23-37-07

you can check it out on my profile

gelstudios commented 6 years ago

your heart image has a hole in it, is that intentional?

deadbaed commented 6 years ago

it is. i am trying to reproduce this http://moziru.com/images/zelda-clipart-8-bit-8.jpg

if you don't like it and you want to get a full heart, that's fine.

On Fri, Feb 9, 2018 at 6:01 PM, Eric Romano notifications@github.com wrote:

your heart image has a hole in it, is that intentional?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gelstudios/gitfiti/pull/52#issuecomment-364493503, or mute the thread https://github.com/notifications/unsubscribe-auth/AIZttdjwtclFFza7kzQreMrrJZgSuqrhks5tTHnXgaJpZM4RlnTD .

Kaligule commented 6 years ago

I see your point, but would like the full hart better. The shiny effect doesn't come out enough with just 7 pixels.

deadbaed commented 6 years ago

alright , i will update my patch .

deadbaed commented 6 years ago

good to merge now ?

deadbaed commented 6 years ago

ready to merge @gelstudios ? although i see some conflicts in the file...

gelstudios commented 3 years ago

this is merged but GH wont detect it, closing