gelstudios / gitfiti

abusing github commit history for the lulz
MIT License
8.07k stars 1.12k forks source link

Removed a manual file handler pitfall #86

Closed NaelsonDouglas closed 1 year ago

NaelsonDouglas commented 3 years ago

The problem There was a case where the code was using a manual file handler pitfall, where a file stream was being opened and closed manually. But since Python supports automatic stream closing using the block 'with', its better to use it instead of the manual close in order to remove a bug vector.

Solution Refactored the code to remove the manual file handler