geluk / pass-winmenu

An easy-to-use password manager for Windows, compatible with pass.
MIT License
385 stars 25 forks source link

Forward SSH passphrase requests to the user #24

Closed geluk closed 6 years ago

geluk commented 6 years ago

If you use an SSH key with a passphrase, it's not possible to use the context menu options in pass-winmenu to synchronise your password repository. Because pass-winmenu launches Git without a shell, Git has no way to request your SSH passphrase, causing it to ignore any passphrase-protected keys, which means it won't be able to connect to the remote repository.

This will probably involve starting an SSH agent and requesting it to load an SSH key, as well as providing it with a passphrase.

geluk commented 6 years ago

https://git-scm.com/docs/gitcredentials

hafstrom commented 6 years ago

I've used both versions in my commit (and message) above in conjunction with native-git. I haven't done much experimenting with builtin so far.

geluk commented 6 years ago

Thanks for the PR. I'll test it to see see how it works, but it seems like a good idea to support GIT_SSH regardless.

geluk commented 6 years ago

Implemented in the pre-release.