geluk / pass-winmenu

An easy-to-use password manager for Windows, compatible with pass.
MIT License
385 stars 25 forks source link

Added the ability to set plink as ssh client when using native-git (with pageant it works for #24) #30

Closed hafstrom closed 6 years ago

hafstrom commented 6 years ago

Another option is to simply set core.sshCommand for the pass repo: git config core.sshCommand '"C:/Program Files/PuTTY/plink.exe"'

hafstrom commented 6 years ago

During my tests I had changed the default location of the store, added a commit to correct this @Baggykiin

geluk commented 6 years ago

Got it. I think it would be good to set ssh-path: null by default as well, in order to not introduce a dependency on Plink by default. Perhaps the comment can be altered slightly to indicate that setting a custom SSH client (such as Plink) here will allow you to use SSH key passwords.

hafstrom commented 6 years ago

Sounds very reasonable. Changed it so default is not to try to override anything.

geluk commented 6 years ago

Merged, thanks!