search

gem-pasteur / Integron_Finder

Bioinformatics tool to find integrons in bacterial genomes
GNU General Public License v3.0
67 stars 22 forks source link

[FEAT] Remove/Relax Matplotlib version requirement #111

Open acarafat opened 1 year ago

acarafat commented 1 year ago

Hello,

We are developing a genome annotation and visualization program beav that relies on Integron Finder. We are using Bioconda to distribute our program. Our visualization script requires Matplotlib >= 3.5.2, whereas the Integron Finder specifies the version ==3.3.3 in the Bioconda recipe. I was wondering if you can possibly remove/relax the requirement.

Thank you so much!

jeanrjc commented 1 year ago

I guess it should be possible. Is there any pb with Matplotlib 3.5.2 @bneron ?

You could also propose a PR, we're short on time to dev Integronfinder right now.

acarafat commented 1 year ago

Thank you so much @jeanrjc. Should I go ahead to propose a PR in the Bioconda recipe?

bneron commented 1 year ago

yes originally I fixed the version to fix some problem in conda in package resolution. but IF works well with matplotlib 3.5.2 So if bioconda can solve the packages dependancies there is no reason to stick on 3.3.3 version

acarafat commented 1 year ago

@bneron @jeanrjc I relaxed the matplotlib version requirement from ==3.3.3 to >=3.3.3 in the Bioconda recipie yaml file. I'll test once the build complete. Thanks!

acarafat commented 1 year ago

@bneron @jeanrjc The bioconda build was successful: https://github.com/bioconda/bioconda-recipes/pull/43671